Dynamic filter #231
Dynamic filter #231
Conversation
| : [col.foreignResource.searchableFields]; | ||
|
|
||
| searchableFields.forEach((fieldName) => { | ||
| if (typeof fieldName !== 'string') { |
There was a problem hiding this comment.
@SerVitasik or text at least
| const targetResource = this.inputConfig.resources.find((r) => r.resourceId === pr.resourceId || r.table === pr.resourceId); | ||
| if (targetResource) { | ||
| const hasField = targetResource.columns.some((targetCol) => targetCol.name === fieldName); | ||
| if (!hasField) { |
There was a problem hiding this comment.
so if at least one resource will not have column it will crash. This should be changed to - if there are no resources which have this column then crash.
Probably a little bit implicit but i suggest next behaviour:
if poly has 2 resources:
- if res A has column C and res be has no col C - then when searching use column C in where of res A query, but dont use in query of res B (in query for res b use columns which exist)
- if both res A and B has col C - use it in both queries (to both resources)
- if no of resources has column C - drop this error here and say explicitly - we can't find this column neither in A nor in B.
So when applying poly search (later in code) - extract subset of this searchable fields which exist in resource and use only them in search with disjunction way
| @@ -905,6 +905,34 @@ export default class AdminForthRestAPI implements IAdminForthRestAPI { | |||
| throw new Error(`Wrong filter object value: ${JSON.stringify(filters)}`); | |||
| } | |||
| } | |||
|
|
|||
| if (search && search.trim() && columnConfig.foreignResource.searchableFields) { | |||
There was a problem hiding this comment.
I think poly case is not implemented here at all - it should do parallel queries
There was a problem hiding this comment.
or probably you can do it on frontend (later) - should be possible also, maybe even better
No description provided.