Add readability.js API #11
Open
+756
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
devinhalladay
commented
Jun 16, 2022
Comment on lines
+31
to
+34
| const matcher: MatcherInterface<any> = { | ||
| inverseName: 'noMark', | ||
| propName: 'mark', | ||
| match(string): MatchResponse<any> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for rendering full article content for a given web article, fetched from Readwise highlight sources.
readerAPI route which returns a readability object via@mozilla/readability. This object includes stringified markup, as well as plain text.interweave, which renders the stringified markup, while parsing it to match a given array of highlights. Any highlight matched within the article will be wrapped in<span className='highlight' />Type(s) of changes
Motivation for PR
Enable reading full articles in Geologies, as well as one of the final steps before completing a functional version of the pinch interaction.
How Has This Been Tested?
Locally with various articles.
This feature does not work yet with any highlights sourced from PDFs.
Applicable screenshots
Follow-up PR