Merge pull request #72 from devit-tel/feature/replace-time-keeper-wit…

…h-reminder Feature/replace time keeper with reminder
devit-tel · Aug 11, 2021 · 058412d · 058412d
2 parents 594502c + 9c9bb68
commit 058412d
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 24 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -34,7 +34,7 @@
     "mongoose": "^5.12.12",
     "mongoose-lean-virtuals": "^0.4.4",
     "node-rdkafka": "^2.10.1",
-    "node-zookeeper-client": "^1.1.0",
+    "node-zookeeper-client": "^1.1.1",
     "ramda": "^0.26.1",
     "tslib": "^1.10.0",
     "uuid": "^3.3.3"

diff --git a/src/kafka/index.ts b/src/kafka/index.ts
@@ -124,7 +124,6 @@ export const pollWithMessage = <T = any>(
       messageNumber,
       (error: LibrdKafkaError, messages: Message[]) => {
         if (error) return reject(error);
-        consumer.commitMessageSync;
         resolve([
           messages.map((message: Message) => {
             return jsonTryParse<T>(message.value.toString());

diff --git a/src/store/redis/taskInstance.ts b/src/store/redis/taskInstance.ts
@@ -96,6 +96,10 @@ export class TaskInstanceRedisStore extends RedisStore
       `${prefix}.workflow-task.${workflowId}`,
     );
 
+    if (!taskKeys.length) {
+      return [];
+    }
+
     const tasksString = await this.client.mget(
       ...taskKeys.map((taskId: string) => `${prefix}.task.${taskId}`),
     );