-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: add some tweaks to nvidia docker #2171
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2171 +/- ##
==========================================
- Coverage 87.03% 86.92% -0.12%
==========================================
Files 223 223
Lines 39969 39969
Branches 7302 7302
==========================================
- Hits 34787 34742 -45
- Misses 4600 4650 +50
+ Partials 582 577 -5
|
Probably we can drop it NVC for openmp offloading on NVidia cards That's completely fine by me IIRC, we're still stuck with our own fork of clang, so one more reason to drop it. Can we try again NVC + openmp offloading, now that we finally have NVC 23.5 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would vote for dropping as well...not popular, not faster, cumbersome for non-docker....
But will we also drop related infrastructure?
Yes Ok removing clang build and replacing by nvc |
645309c
to
34cfdf4
Compare
8a28529
to
36c6715
Compare
c884a9d
to
ec38066
Compare
.github/workflows/docker-devito.yml
Outdated
flag: '--gpus all' | ||
- base: 'bases:nvidia-nvc' | ||
tag: 'nvidia-nvc-omp' | ||
flag: '--gpus all --env DEVITO_LABGUAGE=openmp' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LAN*
f8e0721
to
5ac55c9
Compare
5ac55c9
to
091dbb8
Compare
From @kenhester suggestions
Should fix issues with #2023 as cupy-cuda12x seems to install and work fine inside the image
To be discussed, do we keep nvidia-clang in CI