Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Widescreen from Breaking Applications #105

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

Fancy2209
Copy link

@Fancy2209 Fancy2209 commented Feb 6, 2025

Fix to prevent apps from dying when/if devkitPro/SDL#91 gets merged, as it reports the screen width as 854 so apps know it's widescreen, but the viewport and scissor can't be over 640.

Just making sure developers don't have their app break without knowing why :)

@Fancy2209 Fancy2209 requested a review from mardy February 7, 2025 17:38
@Fancy2209 Fancy2209 changed the title Prevent SDL2 Widescreen Support from breaking apps Prevent Widescreen from Breaking Applications Feb 7, 2025
Copy link
Collaborator

@mardy mardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mardy mardy merged commit 50c5bbf into devkitPro:master Feb 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants