fix usbkeyboard build #23
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for that fix. i could have sworn i build it locally before merging but apparently i didn't. thats a fail on my end, sorry. as for dolphin, i don't have an idea. afaik this was only tested on real hardware and ill test it again later today and report back |
|
ok so, tested on real hardware and worked with my keyboards. i don't know why dolphin didn't work, but it seems to be a shortcoming on their end. mind reporting it with them using the example as a binary they can test it with? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8667084
that cleanup commit broke it
just wondering, is this known to not work on dolphin? I enabled "Connect USB keyboard" and nothing happens when typing