Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DisposeAsync #7

Merged
merged 1 commit into from
Sep 25, 2024
Merged

DisposeAsync #7

merged 1 commit into from
Sep 25, 2024

Conversation

SimonCropp
Copy link
Contributor

No description provided.

devlead
devlead reviewed Sep 24, 2024
View reviewed changes
Copy link
Owner

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this release file handle as soon as code block scope exited? Previously had issues file still locked when trying to delete.

@SimonCropp
Copy link
Contributor Author

it should behave the same as the previous using, but it will call disposeasync instead of dispose.

unless i am missing something?

devlead
devlead approved these changes Sep 25, 2024
View reviewed changes
Copy link
Owner

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests suggests everything works fine. 👍
Thanks for your contribution.

@devlead devlead merged commit c450d40 into devlead:develop Sep 25, 2024
3 checks passed
@SimonCropp SimonCropp deleted the DisposeAsync branch September 26, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlead devlead devlead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @devlead