Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The staging branch #117

Merged
merged 117 commits into from
Jun 29, 2018
Merged

The staging branch #117

merged 117 commits into from
Jun 29, 2018

Conversation

vergeev
Copy link
Contributor

@vergeev vergeev commented May 3, 2018

The branch includes the following PRs:
#93 #96 #97 #98 #100 #114 #116

Starting with the commit caad3f4, the PR further decouples Fiasko's architecture from Devman's.

The PR also fixes a ton of small bugs, the incompatibility with Python 3.5 being among them.

@codecov
Copy link

codecov bot commented May 3, 2018

Codecov Report

Merging #117 into master will decrease coverage by 92.67%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #117       +/-   ##
=========================================
- Coverage   92.67%     0%   -92.68%     
=========================================
  Files          28     31        +3     
  Lines         846    884       +38     
=========================================
- Hits          784      0      -784     
- Misses         62    884      +822
Impacted Files Coverage Δ
fiasko_bro/utils/ast_nodes_validators.py 0% <ø> (ø)
fiasko_bro/pre_validation_checks/__init__.py 0% <ø> (-100%) ⬇️
fiasko_bro/utils/list_helpers.py 0% <ø> (ø)
fiasko_bro/utils/url_helpers.py 0% <ø> (ø)
fiasko_bro/utils/configparser_helpers.py 0% <ø> (ø)
fiasko_bro/utils/ast_helpers.py 0% <0%> (ø)
fiasko_bro/pre_validation_checks/encoding.py 0% <0%> (-100%) ⬇️
fiasko_bro/defaults.py 0% <0%> (ø)
fiasko_bro/pre_validation_checks/bom.py 0% <0%> (-100%) ⬇️
fiasko_bro/utils/code_helpers.py 0% <0%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d302f...9f3b4b3. Read the comment docs.

@Melevir Melevir merged commit 78367be into devmanorg:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants