Skip to content

Commit

Permalink
✅ v1.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@devmount
devmount committed Dec 4, 2020
1 parent 8f215ad commit 626715d
Show file tree
Hide file tree
Showing 3 changed files with 373 additions and 367 deletions.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "third-stats",
"version": "0.8.0",
"version": "1.0.0",
"private": true,
"scripts": {
"serve": "vue-cli-service serve",
Expand Down
2 changes: 1 addition & 1 deletion public/manifest.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ThirdStats",
"version": "0.8.0",
"version": "1.0.0",
"manifest_version": 2,
"description": "__MSG_extensionDescription__",
"author": "Andreas Müller",
Expand Down
Loading

7 comments on commit 626715d

@Eagle3386
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devmount 2 suggestions for improvements:

  1. GitHub doesn't list version 1.0.0 under Releases.
  2. Thunderbird should be capable of listing in-app release notes, but ThirdStats seems to not showing them - maybe this could be automated, i. e. generated GitHub release notes based on commits & pushing them to Mozilla's AMO website (which seems to be the source of in-app release notes), too?

@devmount
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eagle3386 yes sorry, I got interrupted this morning 🙈 will soon be fixed (you're too fast 😅)

@devmount
Copy link
Owner Author

@devmount devmount commented on 626715d Dec 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's online now. I don't know either why ThirdStats isn't showing in-app release notes 🤔 I maintain them since the first release at ATN, e.g.:
https://addons.thunderbird.net/en-US/thunderbird/addon/thirdstats/versions/?page=1#version-1.0.0

@devmount
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eagle3386 I placed this question at the TB topicbox and it's most likely caused by the TB locale not matching en-US:
https://thunderbird.topicbox.com/groups/addons/T58f9665f2ef9e634/show-add-on-release-notes-in-tb

I see if I can at least put the release notes for all English locales at ATN to workaround this.

@Eagle3386
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eagle3386 I placed this question at the TB topicbox and it's most likely caused by the TB locale not matching en-US:
https://thunderbird.topicbox.com/groups/addons/T58f9665f2ef9e634/show-add-on-release-notes-in-tb

Now, this is getting weird - my TB actually is of EN-US locale! 😳😅

I see if I can at least put the release notes for all English locales at ATN to workaround this.

Nevertheless, thanks for that. Hopefully, Mozilla implements the fallback suggested in the topic you've linked to. Would help all people involved a lot..

@devmount
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, this is getting weird - my TB actually is of EN-US locale! 😳😅

Well... 😅

Hopefully, Mozilla implements the fallback suggested

Yes, I hope so too. I'll maintain release notes for all English locales for now.
Btw: You're a emoji reactions master 😂

@Eagle3386
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... 😅

Exactly! 🙈🤣

Yes, I hope so too. I'll maintain release notes for all English locales for now.

Thanks a lot! 💓

Btw: You're a emoji reactions master 😂

Absolutely! Text itself is just not emotional enough for me.. 😅😉

Please sign in to comment.