Skip to content

Commit

Permalink
#315: Fix frozen process after global tool installation with msiexec (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
alfeilex authored Nov 11, 2024
1 parent 55db46d commit af3c4ef
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ The full list of changes for this release can be found in https://github.com/dev

Release with new features and bugfixes:

* https://github.com/devonfw/IDEasy/issues/315[#315]: Fix frozen process after MSI installation
* https://github.com/devonfw/IDEasy/issues/312[#312]: Add ability to prefer git (ssh) protocol instead of https for cloning repo
* https://github.com/devonfw/IDEasy/issues/685[#685]: Upgrades and cleanup of dependencies and according license and doc
* https://github.com/devonfw/IDEasy/pull/693[#693]: Setup not working on Mac
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import com.devonfw.tools.ide.process.EnvironmentContext;
import com.devonfw.tools.ide.process.ProcessContext;
import com.devonfw.tools.ide.process.ProcessErrorHandling;
import com.devonfw.tools.ide.process.ProcessMode;
import com.devonfw.tools.ide.repo.ToolRepository;
import com.devonfw.tools.ide.version.VersionIdentifier;

Expand Down Expand Up @@ -141,7 +142,7 @@ public boolean install(boolean silent, EnvironmentContext environmentContext) {
executable = fileAccess.findFirst(downloadBinaryPath, Files::isExecutable, false);
}
ProcessContext pc = this.context.newProcess().errorHandling(ProcessErrorHandling.LOG_WARNING).executable(executable);
int exitCode = pc.run();
int exitCode = pc.run(ProcessMode.BACKGROUND).getExitCode();
if (tmpDir != null) {
fileAccess.delete(tmpDir);
}
Expand Down

0 comments on commit af3c4ef

Please sign in to comment.