Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanup of GlobalToolCommandlet from PR #684 #751

Open
1 of 2 tasks
hohwille opened this issue Nov 11, 2024 · 0 comments · May be fixed by #763
Open
1 of 2 tasks

Small cleanup of GlobalToolCommandlet from PR #684 #751

hohwille opened this issue Nov 11, 2024 · 0 comments · May be fixed by #763
Assignees
Labels
core FileAccess, ProcessUtil, IdeContext, etc. enhancement New feature or request internal Nothing to be added to CHANGELOG, only internal story

Comments

@hohwille
Copy link
Member

hohwille commented Nov 11, 2024

From PR #684 we have some small left-overs from the review discussion:

  • Move postInstall() to LocalToolCommandlet and remove it from [Global]ToolCommandlet:

But what are we doing with postInstall()

If the process runs in background mode, then message Successfully installed docker in version 1.16.0 will be output immediately after the setup installer window has opened.

We can change the log message but this is the only reasonable behaviour. We trigger the installation and the end-user needs to click through the installation process. This can take a minute or several hours if the user has fallen asleep. Not much that we can do about it...

@hohwille hohwille added enhancement New feature or request internal Nothing to be added to CHANGELOG, only internal story labels Nov 11, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Nov 11, 2024
@hohwille hohwille added the core FileAccess, ProcessUtil, IdeContext, etc. label Nov 11, 2024
@leonrohne27 leonrohne27 self-assigned this Nov 14, 2024
@leonrohne27 leonrohne27 moved this from 🆕 New to 🏗 In progress in IDEasy board Nov 14, 2024
leonrohne27 added a commit to leonrohne27/IDEasy that referenced this issue Nov 14, 2024
Moved the method postInstall from GlobalToolCommandlet to LocalToolCommandlet and changed the installation message so that the user is not getting confused
@hohwille hohwille added this to the release:2024.12.001 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core FileAccess, ProcessUtil, IdeContext, etc. enhancement New feature or request internal Nothing to be added to CHANGELOG, only internal story
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

2 participants