-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#315: Fix frozen process after global tool installation with msiexec #684
Conversation
Pull Request Test Coverage Report for Build 11783435816Details
💛 - Coveralls |
cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfeilex thanks for testing, filing bug and creating PR (including CHANGELOG update) 👍
I left a comment with an alternative suggestion to fix this.
If you agree, please update the PR.
In case you disagree, we could at least explain and document more about why we magically add this /qb
option.
If the installation process of global tools should happen in the background, then this implementation doesn't make sense, does it? We are waiting for an exit code to proceed but if the setup is done by the user in the background, the IDE should output something like But it probably makes sense, as the global installation varies across operating systems. Ultimately, switching to IDEasy/cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java Lines 134 to 147 in 54a8b47
|
IDEasy/cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java Lines 142 to 144 in 071e732
|
Created issue #751 for the discussed improvements. |
Fixes: #315
This PR adds an argument formsiexec
to installmsi
files. With/qb
the installation requires no user interaction, but there is still a UI to see the progress of the installation. This way the process no longer freezeThis PR change the installation process of global tools so that they are run in the background.
Affected tools:
docker, pgadmin