Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#646: Add variable for intellij to disable console log output #729

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

KianRolf
Copy link
Contributor

@KianRolf KianRolf commented Oct 30, 2024

fixes #646

  • gives the user the possibility to enable or disable console log output via IDE_ENABLE_LOG
  • is set to false by default
  • so far is only affecting intellij but intended as a switch for all ide

@KianRolf KianRolf self-assigned this Oct 30, 2024
@KianRolf KianRolf added intellij IntelliJ IDE from Jet-Brains logging labels Oct 30, 2024
@coveralls
Copy link
Collaborator

coveralls commented Oct 30, 2024

Pull Request Test Coverage Report for Build 11596089523

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 66.718%

Totals Coverage Status
Change from base Build 11580911301: 0.003%
Covered Lines: 6283
Relevant Lines: 9073

💛 - Coveralls

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KianRolf thanks for your addition of the IDE_ENABLE_LOG variable. I've added some CRs, please resolve.

CHANGELOG.adoc Show resolved Hide resolved
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the change requests. I think we should also add an entry to our documentation, so the user becomes aware of this feature.

@jan-vcapgemini
Copy link
Contributor

I'm not sure about the naming yet. IDE_ENABLE_LOG could be misinterpreted that the logging is now being done into a file. Maybe we need 2 variables instead? IDE_ENABLE_FILE_LOG (logs intellij errors into log file) and IDE_ENABLE_LOG (disables complete logging)

@KianRolf
Copy link
Contributor Author

KianRolf commented Nov 5, 2024

I think renaming the variable IDE_ENABLE_CONSOLE_LOG avoids the confusion and i also added IDE_ENABLE_CONSOLE_LOG to variables.adoc in documentation.

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution for the naming. Ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intellij IntelliJ IDE from Jet-Brains logging
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Add variable for intellij to disable/modify log output
4 participants