Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#745: fix loading and evaluation of variables #746

Merged
merged 6 commits into from
Nov 11, 2024
Merged

#745: fix loading and evaluation of variables #746

merged 6 commits into from
Nov 11, 2024

Conversation

hohwille
Copy link
Member

@hohwille hohwille commented Nov 5, 2024

fixes #745

  • fix loading of variables with handling of legacy variables
  • log warnings for legacy variables or duplicate variable definition in same file
  • allow overriding of variable with empty value instead of ignoring
  • fix EnvironmentVariables.getToolVersion and prevent NPE
  • improved tests to cover all these edge-cases

@hohwille hohwille added environment EnvironmentCommandlet, env variables, path, etc. bugfix labels Nov 5, 2024
@hohwille hohwille added this to the release:2024.11.001 milestone Nov 5, 2024
@hohwille hohwille self-assigned this Nov 5, 2024
jan-vcapgemini
jan-vcapgemini approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this bugfix. I've added some CRs, please check. Approving so it won't be blocked.

cli/src/test/java/com/devonfw/tools/ide/environment/EnvironmentVariablesPropertiesFileTest.java Outdated Show resolved Hide resolved
cli/src/test/java/com/devonfw/tools/ide/environment/EnvironmentVariablesPropertiesFileTest.java Outdated Show resolved Hide resolved
cli/src/test/resources/com/devonfw/tools/ide/environment/var/devon.properties Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/environment/EnvironmentVariablesPropertiesFile.java Show resolved Hide resolved
@jan-vcapgemini jan-vcapgemini changed the title #745: fix loading and evluation of variables #745: fix loading and evaluation of variables Nov 6, 2024
@coveralls
Copy link
Collaborator

coveralls commented Nov 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11783927545

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 33 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.07%) to 67.267%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/environment/EnvironmentVariables.java 4 82.69%
com/devonfw/tools/ide/environment/AbstractEnvironmentVariables.java 13 78.11%
com/devonfw/tools/ide/environment/EnvironmentVariablesPropertiesFile.java 16 88.04%
Totals Coverage Status
Change from base Build 11783581702: 0.07%
Covered Lines: 6398
Relevant Lines: 9169
💛 - Coveralls

@hohwille hohwille merged commit 2b473ff into devonfw:main Nov 11, 2024
3 checks passed
@hohwille hohwille mentioned this pull request Nov 12, 2024
Open
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

Assignees

@hohwille hohwille

Labels
bugfix environment EnvironmentCommandlet, env variables, path, etc. reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.11.001
Development

Successfully merging this pull request may close these issues.

Maven install fails with NPE
3 participants
@hohwille @coveralls @jan-vcapgemini