generate sql script from entity #1202

lilliCao · 2020-07-01T14:23:00Z

⚠️ THIS PR IS ONLY FOR DISCUSSION⚠️
Relate #955 .

Implements

Generating 1 sql script V0000__Create_{EntityName}.sql for each Entity
Mapping between java type and db type is based on this
Annotations to be considered: Table, Id, JoinColumn, Column, Size, NotNull, ManyToOne, OneToOne, ManyToMany

maybeec · 2020-07-03T06:54:16Z

cobigen-templates/templates-devon4j/src/main/templates/sql_trigger/functions.ftl

+     <#assign type = "BOOLEAN">
+  <#elseif input_type?contains("Instant") || input_type?contains("Timestamp")>
+     <#assign type = "TIMESTAMP">
+  <#elseif input_type?contains("Date") || input_type?contains("Calender")>


I think it is "Calendar" (typo)

If you have types here, please check for the full type name as otherwise, it might have unexpected side effects if there are more than one class named like that.

maybeec · 2020-07-03T06:55:58Z

...von4j/src/main/templates/sql_trigger/templates/V0000__Create_${variables.entityName}.sql.ftl

+        </#if>
+        <#assign columns = columns + [{"name": name, "type":type}]>
+      <#elseif !field.type?starts_with("List<") && !field.type?starts_with("Set<")>
+        <#if field.type?contains("Entity")>


more compliant would be to check if the type name ends with.
As a class named EntityCrawler would even match this check

maybeec · 2020-07-03T06:57:40Z

...von4j/src/main/templates/sql_trigger/templates/V0000__Create_${variables.entityName}.sql.ftl

+          <#assign type = type + " AUTO_INCREMENT">
+        </#if>
+        <#assign columns = columns + [{"name": name, "type":type}]>
+      <#elseif !field.type?starts_with("List<") && !field.type?starts_with("Set<")>


Here I would better ask for instanceof in a java implementation. I think there are already functions to do so.
So you could easily ask JavaUtil.isCollection( for the full qualified type name.
This would even include the cases where you have Collection< or LinkedList< or anything else.

The current implementation of isCollection only checks the field which is declared in the class itself and not from parent class. I added a new implementation to check all field recursively!

maybeec · 2020-07-03T07:01:11Z

cobigen-templates/templates-devon4j/src/main/templates/sql_trigger/functions.ftl

+  <#else>
+     <#assign type = "VARCHAR(255)">
+  </#if> 
+</#macro>


here I would think macro is a little problematic.
In FreeMarker, you have macros and functions.
Macros are program snippets which will be copied to the place and executed there. No isolation of variables etc. such that it might be hard to reuse macros in any place as variables have to have the same name etc.
So what you want to do here is I think better call a freemarker function which returns to you the string of the type, which you can then assign in your template to a local variable.

MikeSchumacherCapgemini

Looks good, but the new Java methods should have test cases to make sure they always work correctly

MikeSchumacherCapgemini · 2020-07-29T08:04:11Z

...es/templates-devon4j/src/main/java/com/devonfw/cobigen/templates/devon4j/utils/JavaUtil.java

+     *            full qualified class name
+     * @return the annotated table name if existed or null
+     */
+    public String getEntityTableName(String className) {


Add a test case for this method to src/test/java/com/devonfw/cobigen/templates/devon4j/test/utils/JavaUtilTest.java

MikeSchumacherCapgemini · 2020-07-29T08:05:32Z

...es/templates-devon4j/src/main/java/com/devonfw/cobigen/templates/devon4j/utils/JavaUtil.java

+     *            full qualified class name
+     * @return the primary key and its type if found or null
+     */
+    public String getPrimaryKey(String className) {


Add a test case for this method to src/test/java/com/devonfw/cobigen/templates/devon4j/test/utils/JavaUtilTest.java

MikeSchumacherCapgemini · 2020-07-29T08:06:48Z

...es/templates-devon4j/src/main/java/com/devonfw/cobigen/templates/devon4j/utils/JavaUtil.java

+     *            {@link String} the name of the field
+     * @return type of the field in String
+     */
+    public String getCanonicalNameOfField(String className, String fieldName) {


Add a test case for this method to src/test/java/com/devonfw/cobigen/templates/devon4j/test/utils/JavaUtilTest.java

MikeSchumacherCapgemini · 2020-07-29T08:07:25Z

...es/templates-devon4j/src/main/java/com/devonfw/cobigen/templates/devon4j/utils/JavaUtil.java

+     *            {@link String} the name of the field
+     * @return true if the field is an instance of java.utils.Collections
+     */
+    public boolean isCollection2(Class<?> pojoClass, String fieldName) {


Add a test case for this method to src/test/java/com/devonfw/cobigen/templates/devon4j/test/utils/JavaUtilTest.java

The base branch was changed.

CLAassistant · 2022-08-03T09:54:03Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 3 committers have signed the CLA.

❌ lilliCao
❌ maybeec
❌ MikeSchumacherCapgemini
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

maybeec · 2022-09-07T14:21:27Z

continued in #1570

lilliCao requested a review from maybeec July 1, 2020 14:23

maybeec requested changes Jul 3, 2020

View reviewed changes

lilliCao requested review from maybeec and MikeSchumacherCapgemini July 20, 2020 11:11

maybeec added templates enhancement labels Jul 27, 2020

MikeSchumacherCapgemini requested changes Jul 29, 2020

View reviewed changes

maybeec added this to the devonfw-templates-20.04.003 milestone Aug 17, 2020

lilliCao added 2 commits August 24, 2020 15:04

generate sql script from entity

d05ea7a

add tests

4e046bf

lilliCao force-pushed the feature/955-sql-generation branch from 1d87bb7 to 4e046bf Compare August 24, 2020 13:09

lilliCao requested a review from MikeSchumacherCapgemini August 24, 2020 13:11

maybeec modified the milestones: devonfw-templates-v20.08.001, devonfw-templates-v20.08.002 Sep 15, 2020

maybeec modified the milestones: devonfw-templates-v20.08.002, devonfw-templates-v20.08.003 Sep 17, 2020

Merge branch 'master' into feature/955-sql-generation

adb4b43

MikeSchumacherCapgemini previously approved these changes Dec 7, 2020

View reviewed changes

MikeSchumacherCapgemini modified the milestones: devonfw-templates-v2020.12.001, devonfw-templates-v2020.12.002 Dec 17, 2020

maybeec changed the base branch from master to develop January 7, 2021 10:11

Merge branch 'develop' into feature/955-sql-generation

4075614

maybeec changed the base branch from develop to master April 28, 2021 11:17

maybeec added 2 commits July 6, 2021 13:13

Merge branch 'master' into feature/955-sql-generation

e3405d7

Merge branch 'master' into feature/955-sql-generation

dd28147

maybeec removed this from the devonfw-templates-v2020.12.002 milestone Jul 8, 2021

MikeSchumacherCapgemini and others added 3 commits July 12, 2021 10:19

Merge branch 'master' into feature/955-sql-generation

a04e687

Merge branch 'master' into feature/955-sql-generation

0e994df

Merge branch 'master' into feature/955-sql-generation

6d1d272

maybeec marked this pull request as draft December 7, 2021 15:37

maybeec removed the enhancement label Apr 14, 2022

maybeec closed this Sep 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

generate sql script from entity #1202

generate sql script from entity #1202

lilliCao commented Jul 1, 2020 •

edited by maybeec

Loading

maybeec Jul 3, 2020

maybeec Jul 3, 2020

maybeec Jul 3, 2020

lilliCao Jul 10, 2020 •

edited

Loading

maybeec Jul 3, 2020

MikeSchumacherCapgemini left a comment

MikeSchumacherCapgemini Jul 29, 2020

MikeSchumacherCapgemini Jul 29, 2020

MikeSchumacherCapgemini Jul 29, 2020

MikeSchumacherCapgemini Jul 29, 2020

CLAassistant commented Aug 3, 2022 •

edited

Loading

maybeec commented Sep 7, 2022

generate sql script from entity #1202

generate sql script from entity #1202

Conversation

lilliCao commented Jul 1, 2020 • edited by maybeec Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lilliCao Jul 10, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MikeSchumacherCapgemini left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CLAassistant commented Aug 3, 2022 • edited Loading

maybeec commented Sep 7, 2022

lilliCao commented Jul 1, 2020 •

edited by maybeec

Loading

lilliCao Jul 10, 2020 •

edited

Loading

CLAassistant commented Aug 3, 2022 •

edited

Loading