324 access resources gui #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
airherna
requested changes
Dec 12, 2022
There was a problem hiding this comment.
url_launcher is a package for Flutter. the lib is not flutter, is just pure Dart, because it has to work with both the CLI and the GUI.
The getResource methods in the façage should just return URL, so that the CLI or the GUI
are the ones that open it using their available methods (For the GUI the url_launcher package and the CLI our own open URL method).
Right now, this will work when called from the GUI, but if we tried to call it from the CLI it will not, because url_launcher depends on flutter packages.
airherna
requested changes
Dec 12, 2022
takeoff/takeoff_gui/lib/features/details/pages/resource_details.dart
Outdated
Show resolved
Hide resolved
airherna
requested changes
Dec 12, 2022
takeoff/takeoff_gui/lib/features/details/pages/resource_details.dart
Outdated
Show resolved
Hide resolved
takeoff/takeoff_gui/lib/features/details/pages/resource_details.dart
Outdated
Show resolved
Hide resolved
takeoff/takeoff_gui/lib/features/details/pages/resource_details.dart
Outdated
Show resolved
Hide resolved
airherna
requested changes
Dec 13, 2022
takeoff/takeoff_lib/lib/src/controllers/cloud/gcloud/gcloud_controller.dart
Outdated
Show resolved
Hide resolved
takeoff/takeoff_lib/lib/src/controllers/cloud/gcloud/gcloud_controller_impl.dart
Outdated
Show resolved
Hide resolved
takeoff/takeoff_gui/lib/features/home/controllers/projects_controller.dart
Outdated
Show resolved
Hide resolved
airherna
requested changes
Dec 13, 2022
Closed
airherna
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.