#1369: added latest stable version pattern #1374
Conversation
to select a latest stable version one can pass *! or something like 1.2*!
github-actions
bot
added
bash
There was a problem hiding this comment.
@MattesMrzik thanks for this great PR. You also cleanup the code removing lots of typos and trailing spaces. Your implementation to get the latest stable version also looks solid and has nice documentation.
As already commented, you are using a tool that is not available on MacOS so you need to adapt that part and find a different solution.
Further you missed a small but important detail from the story demand:
You need to invert the invocations of the functions getLatestSoftwareVersion and getLatestStableSoftwareVersion.
See from IDEasy:
/** {@link VersionIdentifier} "*" that will resolve to the latest stable version. */
public static final VersionIdentifier LATEST = VersionIdentifier.of("*");
If the version is undefined we also want to install the latest stable version, what is the main purpose of the story as devonfw-ide users got unstable versions installed by default if those are the latest ones available.
|
setup test failed with:
|
the line that determined the edition in doGetLatestSoftwareVersion was missing
…est-stable-version-via-version-pattern
There was a problem hiding this comment.
@MattesMrzik thanks for your fix. Now complete and ready for merge. Good job 👍
Closes #1369. To select the latest version (even unstable), one can pass *! or something like 1.2*!