Merge pull request #2763 from devspace-sh/tests/nil_pointer_regressio…

…n_test tests: add regression tests for nil pointer on invalid kubeconfig
devspace-sh · Dec 1, 2023 · 79fa51d · 79fa51d
2 parents ebf5fd2 + fefb7d0
commit 79fa51d
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 2 deletions.
diff --git a/e2e/tests/pipelines/pipelines.go b/e2e/tests/pipelines/pipelines.go
@@ -417,4 +417,26 @@ var _ = DevSpaceDescribe("pipelines", func() {
 		err = devCmd.RunDefault(f)
 		framework.ExpectNoError(err)
 	})
+
+	ginkgo.It("should not panic on inalid kubeconfig", func() {
+		tempDir, err := framework.CopyToTempDir("tests/pipelines/testdata/invalid_kubeconfig")
+		framework.ExpectNoError(err)
+		defer framework.CleanupTempDir(initialDir, tempDir)
+
+		origEnv := os.Getenv("KUBE_CONFIG")
+		defer os.Setenv("KUBE_CONFIG", origEnv)
+
+		os.Setenv("KUBE_CONFIG", "nonexistent.yaml")
+		newEnv := os.Getenv("KUBE_CONFIG")
+		framework.ExpectEqual(newEnv, "nonexistent.yaml")
+
+		devCmd := &cmd.RunPipelineCmd{
+			GlobalFlags: &flags.GlobalFlags{
+				NoWarn: true,
+			},
+			Pipeline: "deploy",
+		}
+		err = devCmd.RunDefault(f)
+		framework.ExpectNoError(err)
+	})
 })
diff --git a/e2e/tests/pipelines/testdata/invalid_kubeconfig/dep1.yaml b/e2e/tests/pipelines/testdata/invalid_kubeconfig/dep1.yaml
@@ -0,0 +1,6 @@
+version: v2beta1
+name: dep1
+
+pipelines:
+  deploy: |-
+    echo "Hello World"
diff --git a/e2e/tests/pipelines/testdata/invalid_kubeconfig/devspace.yaml b/e2e/tests/pipelines/testdata/invalid_kubeconfig/devspace.yaml
@@ -0,0 +1,10 @@
+version: v2beta1
+name: wait
+
+dependencies:
+  dep1:
+    path: dep1.yaml
+
+pipelines:
+  deploy: |-
+    run_dependencies --all
diff --git a/e2e/tests/ssh/ssh.go b/e2e/tests/ssh/ssh.go
@@ -84,7 +84,7 @@ var _ = DevSpaceDescribe("ssh", func() {
 		framework.ExpectNoError(err)
 		ginkgo.DeferCleanup(framework.CleanupTempDir, initialDir, tempDir)
 
-		ns, err := kubeClient.CreateNamespace("ssh")
+		ns, err := kubeClient.CreateNamespace("ssh-without-service")
 		framework.ExpectNoError(err)
 		ginkgo.DeferCleanup(framework.ExpectDeleteNamespace, kubeClient, ns)
 
@@ -137,7 +137,7 @@ var _ = DevSpaceDescribe("ssh", func() {
 		framework.ExpectNoError(err)
 		ginkgo.DeferCleanup(framework.CleanupTempDir, initialDir, tempDir)
 
-		ns, err := kubeClient.CreateNamespace("ssh")
+		ns, err := kubeClient.CreateNamespace("ssh-with-service")
 		framework.ExpectNoError(err)
 		ginkgo.DeferCleanup(framework.ExpectDeleteNamespace, kubeClient, ns)