Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ephemeral toast error #2376

Merged
merged 4 commits into from
Jan 16, 2025
Merged

fix: ephemeral toast error #2376

merged 4 commits into from
Jan 16, 2025

Conversation

shivani170
Copy link
Contributor

@shivani170 shivani170 commented Jan 16, 2025

Description

  • ephemeral error toast
  • GA event on reload resource button
  • fix for branch regex for app group

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1797

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Jan 16, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@shivani170 shivani170 changed the title Fix/ephemeral toast error fix: ephemeral toast error Jan 16, 2025
@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Jan 16, 2025
@shivani170 shivani170 merged commit 4ecae8b into main Jan 16, 2025
14 of 21 checks passed
@shivani170 shivani170 deleted the fix/ephemeral-toast-error branch January 16, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants