Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: build time breakdown #2394

Merged
merged 19 commits into from
Feb 7, 2025
Merged

feat: build time breakdown #2394

merged 19 commits into from
Feb 7, 2025

Conversation

AbhishekA1509
Copy link
Member

@AbhishekA1509 AbhishekA1509 commented Jan 23, 2025 •
edited
Loading

Description

feat: segregate worker status from execution status.

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1614

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

QA

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@AbhishekA1509 AbhishekA1509 self-assigned this Jan 23, 2025
@AbhishekA1509 AbhishekA1509 marked this pull request as draft January 23, 2025 05:45
@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Jan 23, 2025
@AbhishekA1509 AbhishekA1509 reopened this Jan 23, 2025
@AbhishekA1509 AbhishekA1509 changed the title Feat/build time breakdown feat: build time breakdown Jan 23, 2025
@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Jan 23, 2025
@AbhishekA1509 AbhishekA1509 marked this pull request as ready for review January 23, 2025 09:41
eshankvaish
eshankvaish previously approved these changes Jan 24, 2025
View reviewed changes
vivek-devtron
vivek-devtron previously approved these changes Jan 29, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@AbhishekA1509 AbhishekA1509 merged commit e540b7a into develop Feb 7, 2025
9 checks passed
@AbhishekA1509 AbhishekA1509 deleted the feat/build-time-breakdown branch February 7, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivek-devtron vivek-devtron vivek-devtron approved these changes

@eshankvaish eshankvaish eshankvaish left review comments

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

Assignees

@AbhishekA1509 AbhishekA1509

Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhishekA1509 @eshankvaish @vivek-devtron