Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config id is 0 in save notification payload #2409

Merged
merged 10 commits into from
Feb 11, 2025

Conversation

arunjaindev
Copy link
Contributor

@arunjaindev arunjaindev commented Jan 28, 2025

Description

feat: remove sesConfigId from add notification payload and pass in configId
chore: remove notification config call from app group as it is un necessary

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1670

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Jan 28, 2025
@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Jan 28, 2025
AbhishekA1509
AbhishekA1509 previously approved these changes Jan 30, 2025
vivek-devtron
vivek-devtron previously approved these changes Feb 3, 2025
@arunjaindev arunjaindev changed the base branch from develop to release-candidate-v0.29.0 February 11, 2025 10:08
@arunjaindev arunjaindev dismissed vivek-devtron’s stale review February 11, 2025 10:08

The base branch was changed.

@arunjaindev arunjaindev merged commit 75f30a1 into release-candidate-v0.29.0 Feb 11, 2025
6 checks passed
@arunjaindev arunjaindev deleted the feat/notification-config branch February 11, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants