-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: config id is 0 in save notification payload #2409
Merged
arunjaindev
merged 10 commits into
release-candidate-v0.29.0
from
feat/notification-config
Feb 11, 2025
Merged
fix: config id is 0 in save notification payload #2409
arunjaindev
merged 10 commits into
release-candidate-v0.29.0
from
feat/notification-config
Feb 11, 2025
+9
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhishekA1509
previously approved these changes
Jan 30, 2025
…nto feat/notification-config
vivek-devtron
previously approved these changes
Feb 3, 2025
…nto feat/notification-config
…nto feat/notification-config
The base branch was changed.
|
vivek-devtron
approved these changes
Feb 11, 2025
AbhishekA1509
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: remove sesConfigId from add notification payload and pass in configId
chore: remove notification config call from app group as it is un necessary
Fixes https://github.com/devtron-labs/sprint-tasks/issues/1670
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: