feat: integrate configure patch modal and edit patch button #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feat/revamp-deployment-charts
…nto feat/revamp-deployment-charts
…nto feat/revamp-deployment-charts
…nto feat/revamp-deployment-charts
arunjaindev
requested review from
vikramdevtron and
vivek-devtron
as code owners
…nto feat/revamp-deployment-charts
…vtron-labs/dashboard into feat/hibernation-patch
arunjaindev
changed the base branch from
feat/revamp-deployment-charts
to
develop
github-actions
bot
added
the
PR:Issue-verification-failed
…nto feat/hibernation-patch
…abs/dashboard into feat/hibernation-patch
| @@ -0,0 +1,3 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="none" viewBox="0 0 24 24"> | |||
| <path fill="#3B444C" d="m2.77 20.317-.003.75h.002v-.75Zm-.77-.77h-.75v.003l.75-.002Zm20 .03h.75H22ZM2.833 3.65v.75-.75Zm5.488 0v.75-.75Zm.59.244-.53.53.53-.53Zm2.559 3.62a.75.75 0 1 0 1.06-1.06l-1.06 1.06Zm.53 8.442a.75.75 0 0 0 0 1.5v-1.5Zm3.056 1.5h.75v-1.5h-.75v1.5ZM12 9.845a.75.75 0 1 0 0 1.5v-1.5Zm3.056 1.5h.75v-1.5h-.75v1.5Zm0 1.6h-.75v1.5h.75v-1.5Zm3.055 1.5a.75.75 0 0 0 0-1.5v1.5Zm-2.305-7.461v-.75h-1.5v.75h1.5Zm-1.5 13.333v.75h1.5v-.75h-1.5Zm6.953-.75H2.77v1.5h18.49v-1.5Zm-18.488 0a.022.022 0 0 1-.015-.006l-1.06 1.06c.284.285.67.445 1.071.446l.004-1.5Zm-.015-.006a.022.022 0 0 1-.006-.015l-1.5.004c.001.402.161.787.446 1.071l1.06-1.06Zm-.006-.013V6.984h-1.5v12.564h1.5ZM2 7.734h19.167v-1.5H2v1.5Zm19.167 0c.022 0 .043.008.059.024l1.06-1.06a1.584 1.584 0 0 0-1.12-.464v1.5Zm.059.024a.083.083 0 0 1 .024.06h1.5c0-.42-.167-.824-.464-1.12l-1.06 1.06Zm.024.06v11.758h1.5V7.817h-1.5Zm0 11.758a.01.01 0 0 1 .003-.006l1.06 1.06c.28-.28.437-.658.437-1.054h-1.5Zm.003-.006a.009.009 0 0 1 .006-.003v1.5a1.49 1.49 0 0 0 1.054-.437l-1.06-1.06ZM2.75 6.984v-2.5h-1.5v2.5h1.5Zm0-2.5a.09.09 0 0 1 .024-.06l-1.06-1.06c-.297.297-.464.7-.464 1.12h1.5Zm.024-.06a.083.083 0 0 1 .06-.024V2.9c-.42 0-.823.167-1.12.464l1.06 1.06Zm.06-.024H8.32V2.9H2.833v1.5Zm5.487 0c.011 0 .022.003.032.007l.574-1.386a1.583 1.583 0 0 0-.606-.12v1.5Zm.032.007c.01.004.02.01.027.018l1.061-1.06a1.583 1.583 0 0 0-.514-.344l-.574 1.386Zm.027.018 3.09 3.09 1.06-1.062-3.089-3.089-1.06 1.06ZM12 17.455h3.056v-1.5H12v1.5Zm0-6.11h3.056v-1.5H12v1.5Zm3.056 3.1h3.055v-1.5h-3.055v1.5Zm-.75-7.461v13.333h1.5V6.984h-1.5Z"/> | |||
There was a problem hiding this comment.
@uxarya-d Can we use a variant with stroke instead?
AbhishekA1509
requested changes
Feb 4, 2025
src/Pages/GlobalConfigurations/DeploymentCharts/List/DeploymentChartsList.component.tsx
Outdated
Show resolved
Hide resolved
src/Pages/GlobalConfigurations/DeploymentCharts/List/DeploymentChartsList.component.tsx
Show resolved
Hide resolved
src/Pages/GlobalConfigurations/DeploymentCharts/List/DeploymentChartsListHeader.tsx
Outdated
Show resolved
Hide resolved
AbhishekA1509
previously approved these changes
Feb 5, 2025
github-actions
bot
added
PR:Ready-to-Review
|
|
||
| const handleTriggerSorting = (sortKey: DeploymentChartsListSortableKeys) => () => handleSorting(sortKey) | ||
|
|
||
| const sortChartList = (a: DeploymentChartType, b: DeploymentChartType) => { |
There was a problem hiding this comment.
We should extract out this method
vivek-devtron
previously approved these changes
Feb 6, 2025
|
vivek-devtron
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes https://github.com/devtron-labs/sprint-tasks/issues/1548
Type of change
Checklist: