feat: table in RB #2707
Open
feat: table in RB #2707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RohitRaj011
requested changes
May 15, 2025
| } | ||
| } | ||
|
|
||
| const stringComparatorBySortOrder = (a: string, b: string) => a.localeCompare(b) |
There was a problem hiding this comment.
why have we removed search worker
these comparators can be imported from common-lib
There was a problem hiding this comment.
The search worker was not required tbh, if the debounce was working properly
There was a problem hiding this comment.
@vivek-devtron please confirm this
src/components/ResourceBrowser/ResourceList/ClusterUpgradeCompatibilityInfo.tsx
Outdated
Show resolved
Hide resolved
src/components/ResourceBrowser/ResourceList/K8sResourceListTableCellComponent.tsx
Outdated
Show resolved
Hide resolved
src/components/ResourceBrowser/ResourceList/K8sResourceListTableCellComponent.tsx
Outdated
Show resolved
Hide resolved
src/components/ResourceBrowser/ResourceList/K8SResourceList.tsx
Outdated
Show resolved
Hide resolved
src/components/ResourceBrowser/ResourceList/K8SResourceList.tsx
Outdated
Show resolved
Hide resolved
src/components/ResourceBrowser/ResourceList/K8SResourceList.tsx
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
PR:Issue-verification-failed
RohitRaj011
previously approved these changes
May 20, 2025
|
check sonarcloud rating maybe that span can be changed to button tag |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: