Skip to content

feat: Global cluster & env categories #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

feat: Global cluster & env categories #2714

wants to merge 10 commits into from

Conversation

shivani170
Copy link
Contributor

@shivani170 shivani170 commented May 20, 2025 •
edited
Loading

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label May 20, 2025
@shivani170 shivani170 changed the title Feat/cluster env categories feat: Global cluster & env categories May 22, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

AbhishekA1509
AbhishekA1509 reviewed May 23, 2025
View reviewed changes
src/config/constants.ts
@@ -673,6 +673,7 @@ export enum MANIFEST_KEY_FIELDS {
export enum CONFIGURATION_TYPES {
ENVIRONMENT = 'ENVIRONMENT',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should in ClusterAndEnvironments folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhishekA1509 AbhishekA1509 AbhishekA1509 left review comments

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
PR:Issue-verification-failed PR:Issue-verification-failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shivani170 @AbhishekA1509 @vivek-devtron