feat: manual canary control & its visibility #2726
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add BulkSelection Widget - add manage traffic button & menu item - improve layout structure (UI) - improve code structure - code optimization
…hboard into feat/app-group-manage-traffic
feat: update loading card and use from fe-common
feat: EnvironmentOverview - integrate ManageTraffic, BulkSelectionActionWidget
…n-labs/dashboard into feat/feasible-pipelines
feat: add util for getting workflows which can be triggered
feat: Move BulkManageTrafficDrawer to route
| }: AppDetailsCDButtonType): JSX.Element => { | ||
| const history = useHistory() | ||
| const { searchParams } = useSearchString() | ||
| const location = useLocation() | ||
| const queryParams = new URLSearchParams(location.search) | ||
| const mode = queryParams.get('mode') | ||
| const materialType = queryParams.get('materialType') |
There was a problem hiding this comment.
All materialType on this page should be derived from same source
| @@ -232,6 +237,7 @@ const CDMaterial = ({ | |||
| const abortDeployRef = useRef(null) | |||
|
|
|||
| const isPreOrPostCD = stageType === DeploymentNodeType.PRECD || stageType === DeploymentNodeType.POSTCD | |||
| const isCDNode = stageType === DeploymentNodeType.CD | |||
There was a problem hiding this comment.
We should not create this variable it can be inferred by isPreOrPostCD
| @@ -1661,7 +1666,8 @@ const CDMaterial = ({ | |||
| const getDeployButtonIcon = () => { | |||
| if (deploymentWindowMetadata.userActionState === ACTION_STATE.BLOCKED) { | |||
| return null | |||
| } else if (stageType !== STAGE_TYPE.CD) { | |||
| } | |||
| if (stageType !== STAGE_TYPE.CD) { | |||
There was a problem hiding this comment.
We should change this to isPreOrPostCD
…/canary-visibility
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2173
Type of change
Checklist: