-
Notifications
You must be signed in to change notification settings - Fork 55
feat: manual canary control & its visibility #2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- add BulkSelection Widget - add manage traffic button & menu item - improve layout structure (UI) - improve code structure - code optimization
…hboard into feat/app-group-manage-traffic
feat: update loading card and use from fe-common
feat: EnvironmentOverview - integrate ManageTraffic, BulkSelectionActionWidget
…n-labs/dashboard into feat/feasible-pipelines
feat: add util for getting workflows which can be triggered
feat: Move BulkManageTrafficDrawer to route
}: AppDetailsCDButtonType): JSX.Element => { | ||
const history = useHistory() | ||
const { searchParams } = useSearchString() | ||
const location = useLocation() | ||
const queryParams = new URLSearchParams(location.search) | ||
const mode = queryParams.get('mode') | ||
const materialType = queryParams.get('materialType') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All materialType on this page should be derived from same source
@@ -232,6 +237,7 @@ const CDMaterial = ({ | |||
const abortDeployRef = useRef(null) | |||
|
|||
const isPreOrPostCD = stageType === DeploymentNodeType.PRECD || stageType === DeploymentNodeType.POSTCD | |||
const isCDNode = stageType === DeploymentNodeType.CD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not create this variable it can be inferred by isPreOrPostCD
@@ -1661,7 +1666,8 @@ const CDMaterial = ({ | |||
const getDeployButtonIcon = () => { | |||
if (deploymentWindowMetadata.userActionState === ACTION_STATE.BLOCKED) { | |||
return null | |||
} else if (stageType !== STAGE_TYPE.CD) { | |||
} | |||
if (stageType !== STAGE_TYPE.CD) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change this to isPreOrPostCD
|
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2173
Type of change
Checklist: