Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Revamped Notification Doc #26

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ashokdevtron
Copy link
Contributor

  • Rewrote from scratch
  • Added updated images and gifs
  • Added tutorial videos for Email, Slack, Webhook notifications
  • Included RBAC

@ashokdevtron ashokdevtron added the documentation Improvements or additions to documentation label Dec 10, 2024
@ashokdevtron ashokdevtron self-assigned this Dec 10, 2024
@ashokdevtron ashokdevtron requested review from a team as code owners December 10, 2024 16:42
@ashokdevtron ashokdevtron force-pushed the revamp-notification-doc branch from f5b16a3 to 410ff62 Compare December 11, 2024 08:38
badal773
badal773 previously approved these changes Dec 12, 2024
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SMTP and SES is independent, using it interchangeably is confusing for the user.

| Key | Description |
| --- | ----------- |
| **Configuration Name** | Give a name to your SES Configuration, e.g., `Email SES 2024` |
| **Access Key ID** | Valid user ID from your AWS SMTP Settings page, e.g., `AKIAWEAVHF123ABCD123` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@badal773 Shouldn't this be aws accesskey and secret instead of AWS smtp creds?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@ashokdevtron
Copy link
Contributor Author

SMTP and SES is independent, using it interchangeably is confusing for the user.

@abhibhaw, In the case of AWS, SES and SMTP are used in the same breath (snapshot attached below)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants