Mandatory tag #87
Open
Mandatory tag #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prkhrkat
requested review from
vikramdevtron,
nishant-d,
prakarsh-dt and
vivek-devtron
as code owners
nishant-d
requested changes
Dec 30, 2024
| annotations := make(map[string]string) | ||
|
|
||
| // Read labels and annotations from files | ||
| labelsPath := utils.DEVTRON_SELF_DOWNWARD_API_VOLUME_PATH + "/labels" |
| if err != nil { | ||
| log.Println(util.DEVTRON, "error in reading labels from podinfo, err:", err) | ||
| } | ||
| annotationsPath := utils.DEVTRON_SELF_DOWNWARD_API_VOLUME_PATH + "/annotations" |
| labelsPath := utils.DEVTRON_SELF_DOWNWARD_API_VOLUME_PATH + "/labels" | ||
| labelsOut, err := os.ReadFile(labelsPath) | ||
| if err != nil { | ||
| log.Println(util.DEVTRON, "error in reading labels from podinfo, err:", err) |
| } | ||
|
|
||
| // Combine driver options | ||
| driverOptions = getBuildXDriverOptions("labels", labels, driverOptions) |
| return driverOptions | ||
| } | ||
|
|
||
| func parseKeyValuePairs(input string) map[string]string { |
There was a problem hiding this comment.
use std utility function/library
| return keyValuePairs | ||
| } | ||
|
|
||
| func getBuildXDriverOptions(optionType string, options map[string]string, driverOptions string) string { |
There was a problem hiding this comment.
revisit this logic within buildx and explore library
There was a problem hiding this comment.
<img width="876" alt="Screenshot 2024-12-31 at 6 05 34 PM" src="https://git
hub.com/user-attachments/assets/d05eb13b-0790-464e-8a5c-ecd29c5e444f" />
There was a problem hiding this comment.
buildx has also written parsing logic in same manner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.