Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added dynamic label support for prometheus #5128

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

feat: added dynamic label support for prometheus #5128

wants to merge 26 commits into from

Conversation

ShashwatDadhich
Copy link
Contributor

@ShashwatDadhich ShashwatDadhich commented May 17, 2024 •
edited
Loading

Description

added dynamic label support for prometheus

Fixes #5134

How Has This Been Tested?

  • Tested locally
  • Tested by deploying in VM.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.Versions upgrade for libararies

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShashwatDadhich ShashwatDadhich changed the title added dynamic label support for prometheus feat: added dynamic label support for prometheus May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron left review comments

@ShashwatDevtron ShashwatDevtron ShashwatDevtron left review comments

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Capability for providing custom labels for orchestrator apis to be exposed for prometheus metrics
3 participants
@ShashwatDadhich @vikramdevtron @ShashwatDevtron