chore: chart service crud and configProperties #6642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamayushm
requested review from
vikramdevtron,
nishant-d,
prakarsh-dt and
vivek-devtron
as code owners
Ash-exp
requested changes
Jun 13, 2025
| @@ -567,7 +567,7 @@ func (handler AppListingRestHandlerImpl) FetchResourceTree(w http.ResponseWriter | |||
| common.WriteJsonResp(w, fmt.Errorf("unauthorized user"), nil, http.StatusForbidden) | |||
| return | |||
| } | |||
| envDeploymentConfig, err := handler.deploymentConfigService.GetConfigForDevtronApps(appId, envId) | |||
| envDeploymentConfig, err := handler.deploymentConfigService.GetConfigForDevtronApps(nil, appId, envId) | |||
There was a problem hiding this comment.
We should create add a new method GetConfigForDevtronAppsWiithTx to the interface and internally handle nil param.
Ash-exp
requested changes
Jun 14, 2025
| if err != nil { | ||
| impl.logger.Errorw("error in saving deployment config", "appId", templateRequest.AppId, "err", err) | ||
| return nil, err | ||
| } | ||
|
|
||
| err = impl.updateChartLocationForEnvironmentConfigs(newCtx, templateRequest.AppId, chart.ChartRefId, templateRequest.UserId, version) | ||
| err = impl.updateChartLocationForEnvironmentConfigs(newCtx, tx, templateRequest.AppId, chart.ChartRefId, templateRequest.UserId, version) |
There was a problem hiding this comment.
func (impl *DeploymentConfigReadServiceImpl) parseAppLevelMigrationDataForDevtronApps(appId int) (*bean.DeploymentConfig, error) func (impl *DeploymentConfigReadServiceImpl) parseAppLevelReleaseConfigForDevtronApp(appId int, appLevelConfig *bean.DeploymentConfig) (*bean.ReleaseConfiguration, error)Both these functions should use the tx.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 2763127 | Triggered | Generic High Entropy Secret | 3c0f6c8 | scripts/devtron-reference-helm-charts/cronjob-chart_1-6-0/secrets-test-values.yaml | View secret |
| 141558 | Triggered | Generic High Entropy Secret | 3c0f6c8 | scripts/devtron-reference-helm-charts/cronjob-chart_1-6-0/env-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2107
Adding tx in chart service and propertiesService
Checklist:
Does this PR introduce a user-facing change?