feat: added support for connecting to registries behind proxy or ssh servers #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version up for helm package
kartik-579
requested changes
Feb 22, 2024
go.mod
Outdated
Comment on lines
25
to
29
| helm.sh/helm/v3 v3.14.2 | ||
| k8s.io/api v0.29.0 | ||
| k8s.io/apimachinery v0.29.0 | ||
| k8s.io/cli-runtime v0.29.0 | ||
| k8s.io/client-go v0.29.0 |
There was a problem hiding this comment.
why are we updating this? not recommended . Need to revert these
pkg/cluster/ClusterRepository.go
Outdated
| K8sVersion string `sql:"k8s_version"` | ||
| ErrorInConnecting string `sql:"error_in_connecting"` | ||
| InsecureSkipTlsVerify bool `sql:"insecure_skip_tls_verify"` | ||
| ClusterConnectionConfig *repository.ServerConnectionConfig |
There was a problem hiding this comment.
backward compatibility will be needed here
Comment on lines
42
to
48
| func (repo *ServerConnectionRepositoryImpl) Save(model *ServerConnectionConfig) error { | ||
| return repo.dbConnection.Insert(model) | ||
| } | ||
|
|
||
| func (repo *ServerConnectionRepositoryImpl) Update(model *ServerConnectionConfig) error { | ||
| return repo.dbConnection.Update(model) | ||
| } |
Comment on lines
+160
to
+165
| func (impl HelmAppServiceImpl) GetNewRegistryClient(registryCredential *client.RegistryCredential) (*registry.Client, *client.RegistryCredential, error) { | ||
| registryClient, err := registry.NewClient() | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| return registryClient, registryCredential, err |
There was a problem hiding this comment.
looks like no significance of registryCredential in this method
| @@ -103,16 +104,16 @@ type HelmAppService interface { | |||
| } | |||
|
|
|||
| type HelmAppServiceImpl struct { | |||
| logger *zap.SugaredLogger | |||
There was a problem hiding this comment.
any reason for converting these to uppercase?
| @@ -826,9 +835,11 @@ func (impl HelmAppServiceImpl) installRelease(ctx context.Context, request *clie | |||
| } | |||
|
|
|||
| //oci registry client | |||
| registryClient, err := registry.NewClient() | |||
| var registryClient *registry.Client | |||
There was a problem hiding this comment.
can remove this since this is to be get by method
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.