Add coala support and fix/lint files #121
Conversation
| @@ -0,0 +1,41 @@ | |||
| [Default] | |||
| ignore = .tox/**, .gitignore, .gitreview, .gitmodules, **/provisioning/roles/** | |||
There was a problem hiding this comment.
.gitreview, .gitmodules, /provisioning/roles/
Don't apply to this repo
There was a problem hiding this comment.
Working on it. Sorry, shouldn't have blindly copied the coafile. One thing, is it fine to keep .tox/** and the check on .sh files?
There was a problem hiding this comment.
There aren't any .sh files in this repo (find . -name "*.sh" ) and thinking about Puppet I can't imagine we'll end up writing shell helpers or something, so I guess it can be removed.
Sorry, shouldn't have blindly copied the coafile.
np, just include "WIP" (work in progress) in the commit message if you're planning on updating the commit
There was a problem hiding this comment.
Ah, missed tox question. Yes, I guess we can remove that too, we use Rakefile for that job in puppet
There was a problem hiding this comment.
coala has PuppetLintBear. We can add that for files = **/*.pp. I am currently writing a bear for Ansible which should be updated in the new release.
There was a problem hiding this comment.
I added bear for puppet. For now, I'm ignoring class-name related and some line-length warnings by puppet bear.
And for Ruby, what Bear should we go for RuboCopBear or RubySyntaxBear? RuboCopBear gives a lot of warnings, a lot like "Method/class has too many lines", line-length, using Ruby 1.9 hash syntax, use of braces etc while RubySyntaxBear just checks for the syntax and has few (5-6) warnings. We can go with the first one, ignore all the warnings for now and follow it in future. @dfarrell07 what do you suggest?
There was a problem hiding this comment.
@umeshksingla The more linters the better? I don't have a strong preference, whatever you think's best. :)
| ignore = .tox/**, .gitignore, .gitreview, .gitmodules, **/provisioning/roles/** | ||
| use_spaces = True | ||
|
|
||
| [DOCS] |
| files = ./**/*.markdown, ./**/*.md | ||
| default_actions = MarkdownBear: ApplyPatchAction | ||
|
|
||
| [dockerfile] |
| bears = ShellCheckBear | ||
| files = ./**/*.sh | ||
|
|
||
| [python] |
| files = ./**/*.py | ||
| default_actions = PyUnusedCodeBear: ApplyPatchAction | ||
|
|
||
| [autopep8] |
| @@ -18,17 +18,17 @@ env: | |||
| - PUPPET_VERSION="~> 4.3.0" | |||
| matrix: | |||
| exclude: | |||
| - rvm: 2.2.3 | |||
There was a problem hiding this comment.
All of these conflict with #120
There was a problem hiding this comment.
This changes only the indentation, should I ignore this file for these changes for now?
There was a problem hiding this comment.
#120 has been merged so maybe you can rebase to include those changes
umeshksingla
changed the title
Additional dependencies - puppet-lint, xmllint, rubocop Only very obvious changes have been made, ignoring class-name, line-length, string-literal related warnings Signed-off-by: Umesh Singla <[email protected]>
|
Needs to rebase to include #120, see if the tests pass after |
|
All checks have passed now, so you can merge, I suppose. |
|
Looks great, thanks! 👍 |
umeshksingla
changed the title
No description provided.