Add a CompactReport reporter to raclette #19
Conversation
| self.writer.with_color(term::color::BRIGHT_BLACK, |out| { | ||
| writeln!(out, "(in {:?})", dur).unwrap(); |
There was a problem hiding this comment.
Not sure it's a good default, especially for dark backgrounds. I couldn't see the time on the screenshot you've sent me at all. I knew it's there, but couldn't really read it. Maybe use gray instead?
There was a problem hiding this comment.
Sure, that's fine.
| }); | ||
| } | ||
|
|
||
| let (lbl, color) = if self.stats.ok() { |
There was a problem hiding this comment.
| let (lbl, color) = if self.stats.ok() { | |
| let (label, color) = if self.stats.ok() { |
Saving 2 symbols is probably not worth it.
|
|
||
| write!(self.writer, "\nSummary: ").unwrap(); | ||
| self.writer | ||
| .with_color(color, |out| write!(out, "{} ", lbl).unwrap()); |
There was a problem hiding this comment.
| .with_color(color, |out| write!(out, "{} ", lbl).unwrap()); | |
| .with_color(color, |out| write!(out, "{} ", label).unwrap()); |
|
|
||
| fn done(&mut self) { | ||
| for (name, (dur, res)) in self.results.iter() { | ||
| let (lbl, color) = match res { |
There was a problem hiding this comment.
| let (lbl, color) = match res { | |
| let (label, color) = match res { |
| }; | ||
|
|
||
| self.writer.with_color(color, |out| { | ||
| write!(out, "{} ", lbl).unwrap(); |
There was a problem hiding this comment.
| write!(out, "{} ", lbl).unwrap(); | |
| write!(out, "{} ", label).unwrap(); |
|
|
||
| fn report(&mut self, result: &CompletedTask) { | ||
| self.stats.update(result); | ||
| self.results.insert( |
There was a problem hiding this comment.
Is it really that important to have test labels sorted? I assume most users will prefer interactive output to waiting until the very last test completes just in order to see the test labels sorted...
There was a problem hiding this comment.
But when using --format compact --nocapture you'll see the interactive output. I really want a list of all executed tests at the end. Precisely so its easy to see what happened after a long test run.
If the users prefer, they can stick with --format libtest for a more familiar report format.
There was a problem hiding this comment.
But then the test logs will form one huge blob and it will be hard to find where one test begins and the other test ends. Also note that libtest format explicitly enumerates all the failed test in the summary, which is what people should probably care about the most.
| Status::Success => ("pass", GREEN), | ||
| Status::Failure(_) => ("fail", RED), | ||
| Status::Signaled(_) => ("sign", YELLOW), | ||
| Status::Timeout => ("tout", RED), |
There was a problem hiding this comment.
tout
I'd never have guessed what that means :)
Consider using longer labels, padding them with spaces if needed.
| ("FAIL", BRIGHT_RED) | ||
| }; | ||
|
|
||
| write!(self.writer, "\nSummary: ").unwrap(); |
There was a problem hiding this comment.
So if the test fails, users won't have any idea why?
There was a problem hiding this comment.
No. If the user doesn't run with --nocapture they won't know why.
| @@ -125,6 +128,7 @@ fn parse_format(input: &str) -> Result<Format, String> { | |||
| "libtest" => Ok(Format::LibTest), | |||
| "json" => Ok(Format::Json), | |||
| "tap" => Ok(Format::Tap), | |||
| "compact" => Ok(Format::Compact), | |||
There was a problem hiding this comment.
Do we also need to update the help string?
There was a problem hiding this comment.
Good catch, thanks. Will do
| @@ -70,7 +70,7 @@ const NUM_IGNORED: usize = 1; | |||
|
|
|||
| #[test] | |||
| fn raclette_sample_main() { | |||
| let completed_tasks = default_main(Config::default().format(config::Format::Json), tests()); | |||
| let completed_tasks = default_main(Config::default().format(config::Format::Compact), tests()); | |||
There was a problem hiding this comment.
Is it just for testing?
No description provided.