-
Notifications
You must be signed in to change notification settings - Fork 5
ICRC-124: blocks for recording management actions -- stopping, unstopping and deactivating ledgers #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
ICRCs/ICRC-124/ICRC-124.md:69
- [nitpick] Consider using consistent metadata keys across the examples (e.g., 'reason' in the pause example versus 'note' in the unpause example) to improve clarity and ease of parsing.
record { "reason"; variant { Text = "DAO vote: pause due to upgrade prep" }}
ICRCs/ICRC-124/ICRC-124.md
Outdated
|
||
## Overview of Block Types | ||
|
||
- **Pause Ledger**: `124pause` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The identifier '124pause' is used here, but the PR metadata description references '123pause'. Please confirm the intended block type and update the identifier consistently.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Real World Asset ledgers require several management APIs that would allow authorised entities to carry out ledger changes. This standard introduces three new blocktypes:
123pause
that records that all transactions on the ledger were paused by an authorised party123unpause
that records that a paused ledger was unpause by an authorised party123deactivate
that records that a ledger was deactivated by an authorised party