Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add penalty for unhealthy nodes in latency-based routing #581

Draft
wants to merge 3 commits into
base: dynamic_route
Choose a base branch
from
Draft

chore: add penalty for unhealthy nodes in latency-based routing #581

wants to merge 3 commits into from

Conversation

nikolay-komarevskiy
Copy link
Contributor

@nikolay-komarevskiy nikolay-komarevskiy commented Aug 12, 2024 •
edited
Loading

Description

When a node is detected as unhealthy, we take the following actions:

  • Remove the node entirely from the routing.
  • Penalize its moving average by adding a specified value to the stored latency window. This ensures that any node exhibiting intermittent outages is appropriately penalized.

Previous approach was to simply remove the node from routing.

Extended the test_update_for_existing_node_succeeds().

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@nikolay-komarevskiy nikolay-komarevskiy changed the base branch from main to dynamic_route August 12, 2024 08:36
@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/change-latency-based-routing branch from 68171e3 to ddd01e5 Compare August 12, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikolay-komarevskiy @adamspofford-dfinity