Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Internet Identity integration in vetKD examples and make them work in Safari #1007

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix Internet Identity integration in vetKD examples and make them work in Safari #1007

merged 1 commit into from
Oct 1, 2024

Conversation

fspreiss
Copy link
Member

  • Fixes the Internet Identity (II) integration in the vetKD examples by using the new environment variables for canister IDs (see changelog of SDK 0.18)
  • Makes the example work in Safari by removing the upgrade-insecure-requests; content security policy (CSP) and by using localhost instead of 127.0.0.1 when calling II.

@fspreiss fspreiss marked this pull request as ready for review September 27, 2024 21:54
@fspreiss fspreiss requested a review from a team as a code owner September 27, 2024 21:54
frederikrothenberger
frederikrothenberger approved these changes Oct 1, 2024
View reviewed changes
Copy link

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fspreiss fspreiss requested a review from altkdf October 1, 2024 14:48
@fspreiss fspreiss merged commit 3a7baf2 into master Oct 1, 2024
6 checks passed
@fspreiss fspreiss deleted the fspreiss/fix-vetkd-ii-integration branch October 1, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

@altkdf altkdf altkdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fspreiss @frederikrothenberger @altkdf