chore: implement Internet Identity example recommendations #1033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some recommendations I have on best practices in the II example project.
Important and functional changes
create
should not be invoked during thelogin
flowclick
event leads browsers to treat the interaction as a popup and reject it. This is a particular footgun for Safari mobilelogin
button andgreet
button until the authClient is readyPromise
wrapping oflogin
await
is fancy, but the actual browser API is based around callbacks and events, andonSuccess
andonError
are adequate.reject
ed in theonError
callbackLess important (semantic HTML, a11y, and style)
window.greetActor
andwindow.authClient
instead of local variables so new devs can play with the objects in the console. We DO NOT have to accept this change - it's just an idea I hadform
elements are unnecessary withoutinput
elements, and don't add any semantic value. I prefer<button type="button">
over an empty form, and then we don't need to handlesubmit
events