Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Motoko project READMEs #1070

Merged
merged 20 commits into from
Jan 9, 2025
Merged

Update Motoko project READMEs #1070

merged 20 commits into from
Jan 9, 2025

Conversation

jessiemongeon1
Copy link
Contributor

The example README files are no longer used on the Dev Docs, so the keyword tags and format can be adjusted to read best on GitHub.

Each README has also been updated to fit latest style guide practices.

@jessiemongeon1 jessiemongeon1 requested review from a team as code owners December 18, 2024 22:16
@jessiemongeon1 jessiemongeon1 requested a review from a team December 18, 2024 22:16
@jessiemongeon1 jessiemongeon1 requested review from a team as code owners December 18, 2024 22:16
altkdf
altkdf previously approved these changes Dec 19, 2024
View reviewed changes
reigj1
reigj1 previously approved these changes Dec 19, 2024
View reviewed changes
fspreiss
fspreiss reviewed Dec 19, 2024
View reviewed changes
motoko/encrypted-notes-dapp-vetkd/README.md Outdated Show resolved Hide resolved
motoko/encrypted-notes-dapp-vetkd/README.md Outdated Show resolved Hide resolved
motoko/threshold-schnorr/README.md Outdated Show resolved Hide resolved
motoko/vetkd/README.md Outdated Show resolved Hide resolved
nathanosdev
nathanosdev previously approved these changes Dec 19, 2024
View reviewed changes
fspreiss
fspreiss reviewed Dec 19, 2024
View reviewed changes
motoko/token_transfer/README.md Outdated Show resolved Hide resolved
motoko/token_transfer_from/README.md Outdated Show resolved Hide resolved
@jessiemongeon1 jessiemongeon1 dismissed stale reviews from nathanosdev, reigj1, and altkdf via 17d0ac3 December 19, 2024 14:57
@jessiemongeon1 jessiemongeon1 requested review from a team as code owners December 19, 2024 15:47
jessiemongeon1
jessiemongeon1 commented Dec 19, 2024
View reviewed changes
rust/hello/README.md Outdated Show resolved Hide resolved
nathanosdev
nathanosdev previously approved these changes Jan 6, 2025
View reviewed changes
fspreiss
fspreiss previously approved these changes Jan 7, 2025
View reviewed changes
maksymar
maksymar previously approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@maksymar maksymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

execution team LGTM

rvanasa
rvanasa previously approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@rvanasa rvanasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marc0olo
marc0olo requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@marc0olo marc0olo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessiemongeon1 also some step references here to fix I think. additionally a strange change in the dfx.json in the token_transfer_from example which should be revisited

@marc0olo
Copy link
Member

marc0olo commented Jan 7, 2025

it is a bit unfortunate that all other reviews are now dismissed 🤔

bitdivine
bitdivine approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@bitdivine bitdivine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might want to double check with @lmuntaner

motoko/internet_identity_integration/README.md Show resolved Hide resolved
lmuntaner
lmuntaner approved these changes Jan 9, 2025
View reviewed changes
Copy link

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the II part motoko/internet_identity_integration/README.md

@jessiemongeon1 jessiemongeon1 merged commit 59b4cff into master Jan 9, 2025
52 of 54 checks passed
@jessiemongeon1 jessiemongeon1 deleted the update-motoko-readmes branch January 9, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksymar maksymar maksymar approved these changes

@nathanosdev nathanosdev nathanosdev approved these changes

@marc0olo marc0olo marc0olo approved these changes

@bitdivine bitdivine bitdivine approved these changes

@lmuntaner lmuntaner lmuntaner approved these changes

@fspreiss fspreiss fspreiss approved these changes

@rvanasa rvanasa rvanasa approved these changes

@reigj1 reigj1 Awaiting requested review from reigj1

@altkdf altkdf Awaiting requested review from altkdf

@sea-snake sea-snake Awaiting requested review from sea-snake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.