-
Notifications
You must be signed in to change notification settings - Fork 426
Refactor(Rust/Hello-world): Refactor functions and update dependencies for improved codebase #1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
greet
and set_greeting
function to improve code
greet
and set_greeting
function to improve code
Thank you very much @gianalarcon! This PR could be merged as-is, but the ICP Ninja backend currently still struggles with the new CDK version. Because of that I will not quite yet merge this PR. ETA: 1-2 weeks |
Co-authored-by: Severin Siffert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't forgotten about you! The difficulties with ic-cdk are finally resolved, and Ninja uses the new build server, so it can also handle the new cdk version.
With this change we should finally be good to merge, and sorry for letting you wait for so long
Co-authored-by: Severin Siffert <[email protected]>
Overview
This PR makes several improvements to the codebase:
The
greet
function:with_borrow
closureThe
set_greeting
function:Updates the
ic-cdk
dependency from version "0.16.0" to "0.18.2"Considerations
What impact will this change have on security, performance, users (e.g. breaking changes) or the team (e.g. maintenance costs)?
Both changes maintain identical functionality while making the code more concise and idiomatic.