Fix expiry in test-vector #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expiry takes as a constructor argument the time _delta_ in millis. Supplied was the absolute timestamp as a number (but too large to use accurate integer representation). This fixes the bug. In addition, the test vector should be called ICRC-21 rather then ICRC-29.
size-limit report 📦
|
lmuntaner
reviewed
Aug 23, 2024
| @@ -37,7 +37,7 @@ const consentMessageRequest = { | |||
| "4449444C076D7B6C01D880C6D007716C02CBAEB581017AB183E7F1077A6B028BEABFC2067F8EF1C1EE0D026E036C02EFCEE7800401C4FBF2DB05046C03D6FCA70200E1EDEB4A7184F7FEE80A0501060C4449444C00017104746F626905677265657402656E01011E000300", | |||
| ), | |||
| canister_id: Principal.fromHex("00000000006000FD0101"), | |||
| ingress_expiry: new Expiry(1712666698482000000), | |||
There was a problem hiding this comment.
@frederikrothenberger the helper _prepareCborForLedger expects a type Expiry in ingress_expiry.
Apparently it's ok to pass a negative number. Therefore, I calculated the delta.
I'm not sure how then Expiry will convert this to the actual number. There might be a small delay that messes with it.
lmuntaner
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Thanks for the fix @frederikrothenberger .
I push a commit to fix the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Expiry takes as a constructor argument the time delta in millis. Supplied was the absolute timestamp as a number (but too large to use accurate integer representation).
This fixes the bug.
In addition, the test vector should be called ICRC-21 rather then ICRC-29.