Skip to content

Commit

Permalink
chore(IDX): do not bind-mount home (#3982)
Browse files Browse the repository at this point in the history
Do not bind-mount `$HOME` as this is generally really not safe and
clean. User has freedom to bind-mount specific home directories or
entire home via `$HOME/.container-run.conf`. See below.

```bash
❯ cat ~/.container-run.conf
PODMAN_RUN_USR_ARGS=(
    --mount type=bind,source=${HOME}/dev,target=/home/ubuntu/dev
    --mount type=bind,source=${HOME}/.kube,target=/home/ubuntu/.kube
)
```
Having `$HOME` bind-mounted presented itself to be an issue with release
verification of [this
release](https://forum.dfinity.org/t/proposal-to-elect-new-release-rc-2025-02-13-03-06).
Users tried to verified the build on AWS EC2 instance. It it yet not
clear whether recent related code changes
[here](#3752) are related.
  • Loading branch information
marko-k0 authored Feb 17, 2025
1 parent 9ef5605 commit 7ac415c
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion ci/container/container-run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ fi

PODMAN_RUN_ARGS+=(
--mount type=bind,source="${REPO_ROOT}",target="${WORKDIR}"
--mount type=bind,source="${HOME}",target="${HOME}"
--mount type=bind,source="${CACHE_DIR:-${HOME}/.cache}",target="${CTR_HOME}/.cache"
--mount type=bind,source="${HOME}/.ssh",target="${CTR_HOME}/.ssh"
--mount type=bind,source="${HOME}/.aws",target="${CTR_HOME}/.aws"
Expand Down

0 comments on commit 7ac415c

Please sign in to comment.