feat: Adding syncing of NNS released wasm versions #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasa-tomic
changed the title
sasa-tomic
changed the title
sasa-tomic
reviewed
Dec 12, 2024
|
LGTM, thank you!! |
basvandijk
reviewed
Dec 13, 2024
sasa-tomic
reviewed
Dec 16, 2024
sasa-tomic
approved these changes
Dec 17, 2024
basvandijk
approved these changes
Dec 18, 2024
aterga
approved these changes
Dec 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
As per [this conversation](#3148 (comment)) this PR focuses on moving `testnet/mainnet_revisions.json` to the root of repository alongisde `mainnet-canisters.json`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the script used for updating mainnet revisions in testnets and adds the ability for it to be used more robustly while preserving the existing features.
On top of that, this PR extends the
update-mainnet-revisionsworkflow to add one more job that will be run in parallel and will update themainnet-canisters.jsonfile.Example of new successful run: https://github.com/dfinity/ic/actions/runs/12297897124
Example of created PR: #3198