test(nns): Fix flakiness in two nns integration tests #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-dfinity
force-pushed
the
msum/flaky-add-node-test
branch
2 times, most recently
from
ff58d7f to
c188ba6
Compare
max-dfinity
force-pushed
the
msum/flaky-add-node-test
branch
from
c188ba6 to
14d0535
Compare
max-dfinity
changed the title
jasonz-dfinity
approved these changes
Dec 14, 2024
basvandijk
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix a time discrepancy between system time and StateMachine time causing test flakiness when dealing with cryptographic keys in some tests using the Registry.