Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ICP-Ledger): FI-1442: migrate ledger blocks to stable structures #3836

Merged
merged 77 commits into from
Mar 24, 2025

Conversation

maciejdfinity
Copy link
Contributor

@maciejdfinity maciejdfinity commented Feb 6, 2025

This version migrates blocks stored in the ledger to stable structures. This allows the ledger to store more blocks and reduces the need for archiving. The archiving is still performed but its parameters (e.g. trigger_threshold) can be adjusted. The migration is performed using timers, see #3314 description for more details.

@github-actions github-actions bot added the feat label Feb 6, 2025
@maciejdfinity maciejdfinity marked this pull request as ready for review February 27, 2025 13:30
@maciejdfinity maciejdfinity requested a review from a team as a code owner February 27, 2025 13:30
Copy link
Member

@mbjorkqvist mbjorkqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @maciejdfinity!

Copy link
Contributor

@mraszyk mraszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments/suggestions: nothing major => all non-blocking.

@maciejdfinity maciejdfinity added this pull request to the merge queue Mar 24, 2025
Merged via the queue into master with commit 219abad Mar 24, 2025
21 checks passed
@maciejdfinity maciejdfinity deleted the maciej-icp-v5 branch March 24, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants