feat(MR): Basic metrics for best-effort calls #3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an execution_queues_best_effort_message_bytes metric to track the size of the best-effort message memory pool. And break down the call tree metrics along a message class dimension.
derlerd-dfinity
approved these changes
Feb 7, 2025
alexandru-uta
approved these changes
Feb 10, 2025
stiegerc
approved these changes
Feb 10, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
This is a follow-up to this [PR](#3858). `is_best_effort()` already exists for [Response](https://sourcegraph.com/github.com/dfinity/ic@8752c066884802d94674851bf72bc248b654e462/-/blob/rs/types/types/src/messages/inter_canister.rs?L470) and [RequestOrResponse](https://sourcegraph.com/github.com/dfinity/ic@8752c066884802d94674851bf72bc248b654e462/-/blob/rs/types/types/src/messages/inter_canister.rs?L573). There is now a reason to have it on `Request` as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
execution_queues_best_effort_message_bytesmetric to track the size of the best-effort message memory pool. And break down the call tree metrics along a message class dimension.