feat(nns): Validate manage network economics. #3859
Merged
+799
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wong-dfinity-org
force-pushed
the
validate-manage-network-economics
branch
2 times, most recently
from
23bbf78 to
b667d04
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
daniel-wong-dfinity-org
force-pushed
the
support-changing-one-nested-field-in-network-economics-daniel-wong
branch
from
758f276 to
9be881b
Compare
daniel-wong-dfinity-org
force-pushed
the
validate-manage-network-economics
branch
from
5b5ff8b to
5c65af2
Compare
Base automatically changed from
support-changing-one-nested-field-in-network-economics-daniel-wong
to
master
February 10, 2025 20:21
…rotoDecimal (an alias for another type named Decimal).
…t proposal creation.
daniel-wong-dfinity-org
force-pushed
the
validate-manage-network-economics
branch
from
245fe9b to
7459233
Compare
aterga
reviewed
Feb 12, 2025
aterga
reviewed
Feb 12, 2025
aterga
reviewed
Feb 12, 2025
aterga
reviewed
Feb 12, 2025
aterga
reviewed
Feb 12, 2025
aterga
reviewed
Feb 12, 2025
aterga
reviewed
Feb 12, 2025
aterga
requested changes
Feb 12, 2025
…validate after merging anyway.
…r in that the first one is successful, but the second one gets blocked.
…ere where they are needed.
…w perform on ManageNetworkEconomics.
aterga
approved these changes
Feb 12, 2025
daniel-wong-dfinity-org
deleted the
validate-manage-network-economics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference(s)
Closes NNS1-3498.