chore(boundary): add periodic shared salt fetching in ic-boundary
#3887
+408
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolay-komarevskiy
force-pushed
the
komarevskiy/salt-sharing-ic-boundary
branch
from
2acc73d to
fe75bee
Compare
nikolay-komarevskiy
force-pushed
the
komarevskiy/salt-sharing-ic-boundary
branch
from
fe75bee to
572d295
Compare
r-birkner
reviewed
Feb 12, 2025
| loop { | ||
| let query_response = match self | ||
| .agent | ||
| .execute_query(&self.canister_id, "get_salt", Encode!().unwrap()) |
There was a problem hiding this comment.
As long as the data is not certified, we should use an update call for that.
Suggested change
| .execute_query(&self.canister_id, "get_salt", Encode!().unwrap()) | |
| .execute_query(&self.canister_id, &self.canister_id, "get_salt", Encode!().unwrap(), nonce()) |
See here
There was a problem hiding this comment.
good point, yes execute_update() replicated query instead of execute_query()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ic-boundaryfrom the canistersystem-testasserting API boundary nodes retrieve the salt from the canister after its installation