refactor(sns): migrate SNS integration tests / init to sns-gov-api #3918
+464
−258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
anchpop
force-pushed
the
@anchpop/api-sns-tests
branch
from
7644804 to
7971a70
Compare
anchpop
force-pushed
the
@anchpop/api-sns-tests
branch
from
7971a70 to
92b2696
Compare
max-dfinity
reviewed
Feb 12, 2025
| @@ -23,6 +23,7 @@ DEPENDENCIES = [ | |||
| "//rs/nns/handlers/root/interface", | |||
| "//rs/rust_canisters/http_types", | |||
| "//rs/sns/governance", | |||
There was a problem hiding this comment.
are you able to remove the old dependency?
max-dfinity
reviewed
Feb 12, 2025
| @@ -45,6 +45,7 @@ BASE_DEPENDENCIES = [ | |||
| "//rs/rust_canisters/dfn_protobuf", | |||
| "//rs/rust_canisters/on_wire", | |||
| "//rs/sns/governance", | |||
max-dfinity
reviewed
Feb 12, 2025
| @@ -560,8 +560,7 @@ impl Neuron { | |||
| /// that are adopted (then the fees are returned and not owed anymore) or | |||
| /// by transferring funds to the neuron's account and then refreshing the stake. | |||
| pub fn stake_e8s(&self) -> u64 { | |||
| self.cached_neuron_stake_e8s | |||
| .saturating_sub(self.neuron_fees_e8s) | |||
| ic_sns_governance_api::pb::v1::Neuron::from(self.clone()).stake_e8s() | |||
There was a problem hiding this comment.
It seems like you should have this implementation inside the domain model - not use the API version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the SNS integration tests and SNS init were using ic-sns-governance. They should be using ic-sns-governance-api. (That they are not using ic-sns-governance-api is a bug waiting to happen.)
Unfortunately this became a very viral change, so the diff is huge. It also involves a lot of code copying, which might not be the ideal approach.
I may close this PR and choose another route forward tomorrow