fix: switch to checkpoint for wasm binaries in canister snapshots #4777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShuoWangNSL
force-pushed
the
shuo/switch_to_checkpoint_snapshot_wasm
branch
4 times, most recently
from
8985cdc to
ee1a530
Compare
ShuoWangNSL
force-pushed
the
shuo/switch_to_checkpoint_snapshot_wasm
branch
from
d28e399 to
16ab02b
Compare
schneiderstefan
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During checkpointing, we switch to the files in the new checkpoint to back data structures like pagemaps and wasm binaries. This approach should also apply to the wasm binaries of canister snapshots and this PR fixes it.