-
Notifications
You must be signed in to change notification settings - Fork 356
feat: support for external mainnet canisters in the bazel workspace #5938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rs/nervous_system/tools/sync-with-released-nervous-system-wasms/src/main.rs
Outdated
Show resolved
Hide resolved
rs/nervous_system/tools/sync-with-released-nervous-system-wasms/src/main.rs
Show resolved
Hide resolved
rs/nervous_system/tools/sync-with-released-nervous-system-wasms/src/main.rs
Outdated
Show resolved
Hide resolved
rs/nervous_system/tools/sync-with-released-nervous-system-wasms/src/main.rs
Show resolved
Hide resolved
rs/nervous_system/tools/sync-with-released-nervous-system-wasms/src/main.rs
Show resolved
Hide resolved
rs/nervous_system/tools/sync-with-released-nervous-system-wasms/src/main.rs
Outdated
Show resolved
Hide resolved
rs/nervous_system/tools/sync-with-released-nervous-system-wasms/src/main.rs
Outdated
Show resolved
Hide resolved
rs/nervous_system/tools/sync-with-released-nervous-system-wasms/src/main.rs
Show resolved
Hide resolved
rs/nervous_system/tools/sync-with-released-nervous-system-wasms/src/main.rs
Show resolved
Hide resolved
rs/nervous_system/tools/sync-with-released-nervous-system-wasms/src/main.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request changes code owned by the Governance team.
Therefore, make sure that you have done the following (for
Governance-owned code):
-
Add entry(s) to corresponding
unreleased_changelog.md
file(s). This is only necessary if the code changes result in
externally visible behavior changes. -
If there are behavior changes, are they breaking? This is
usually due to some new requirement(s) imposed by the canister,
or removal of guarantees supplied by the canister. If the
changes are breaking, are your clients ready for them? If not,
put your changes behind a "feature flag". If you have a feature
flag, then, do NOT add entrie(s) tounreleased_changelog.md
in this PR, but rather, do that later when you set the flag to
"enable" in another PR. -
Is data migration needed? (If so, make sure it is part of this
PR.) -
Does this require security review? At the very least, you can
tell security team about this PR, and let them decide whether
the risk warrants their review.
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, look
for where it says this bot is requesting changes, click the three
dots on the right, select "Dismiss review", and for each of the
numbered items listed above, supply one of the following reasons:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md
, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
To be more precise, "externally visible behavior change" usually
means that responses differ in some way. However, "externally
visible behavior change" is not limited to that. For example, it
could also means that the canister makes different requests to
other canisters.
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
No canister behavior changes.
This PR adds support for external mainnet canisters in the bazel workspace.
In more detail, this PR
dfinity/cycles-ledger
);{canister_name}.sha256
wherecanister_name
is hard-coded (e.g.,cycles-ledger.wasm.gz
);GITHUB_TOKEN
to prevent rate-limiting;This PR has been tested manually by changing the module hash and tag of the mainnet cycles ledger canister in the json file and running
bazel run //rs/nervous_system/tools/sync-with-released-nervous-system-wasms
to confirm that the json file is properly regenerated.Follow up improvements of the NNS bot are tracked in this ticket.