refactor(sns): NNS1-3207: Use NeuronRecipes in SNS Swap #629

anchpop · 2024-07-26T01:25:58Z

#596 added NeuronRecipes in ClaimSwapNeuronsRequest, a replacement for NeuronParameters. This PR uses it in SNS Swap

| Next PR >

rs/sns/swap/src/swap.rs

rs/sns/swap/tests/swap.rs

rs/sns/swap/src/swap.rs

…ecycle tests (#705) This PR adds the newly expected hotkeys from NNS neurons of Neurons' Fund participants as SNS neuron permissions of SNS neurons created after a successful swap with Neurons' Fund participation. Additionally, the code is slightly refactored so that the test can reuse the algorithm for picking subsets of hotkeys (in cases when there are too many of them on the NNS side). < [Previous PR](#629) | --------- Co-authored-by: Andre Popovitch <[email protected]>

andrew-lee-work · 2024-08-12T19:49:36Z

rs/sns/swap/src/swap.rs

-                        ERROR,
-                        "Missing neuron_attributes information for neuron recipe {:?}",
-                        recipe,
+            // Here we convert the SnsNeuronRecipe (a Swap concept) to an SnsNeuronRecipe (an SNS


is this a typo?

github-actions bot added the refactor label Jul 26, 2024

anchpop force-pushed the @anchpop/neuron-recipies-refactor branch 4 times, most recently from fd4af6d to 4328a29 Compare July 26, 2024 02:54

anchpop force-pushed the @anchpop/NNS1-3207 branch 2 times, most recently from 1b3a950 to 194bcfc Compare July 26, 2024 15:21

anchpop force-pushed the @anchpop/neuron-recipies-refactor branch 3 times, most recently from eea0ce9 to 43e73e7 Compare July 26, 2024 17:46

anchpop force-pushed the @anchpop/NNS1-3207 branch from 194bcfc to ab60c3c Compare July 26, 2024 17:47

anchpop force-pushed the @anchpop/neuron-recipies-refactor branch 3 times, most recently from e3afc60 to 51319f0 Compare July 26, 2024 21:24

anchpop force-pushed the @anchpop/NNS1-3207 branch from ab60c3c to 4e9dce6 Compare July 29, 2024 16:02

anchpop force-pushed the @anchpop/neuron-recipies-refactor branch 5 times, most recently from aa4e3f4 to e3d0da6 Compare July 29, 2024 19:21

anchpop force-pushed the @anchpop/NNS1-3207 branch from 4e9dce6 to faeb3a6 Compare July 29, 2024 20:49

anchpop force-pushed the @anchpop/neuron-recipies-refactor branch from e3d0da6 to be272ad Compare July 30, 2024 15:20

anchpop force-pushed the @anchpop/NNS1-3207 branch from faeb3a6 to b1b8d65 Compare July 30, 2024 15:38

anchpop force-pushed the @anchpop/neuron-recipies-refactor branch 2 times, most recently from b61bdd6 to 923f0a3 Compare July 30, 2024 16:15

anchpop marked this pull request as ready for review July 30, 2024 16:39

anchpop requested a review from a team as a code owner July 30, 2024 16:39

anchpop marked this pull request as draft July 30, 2024 16:39

anchpop force-pushed the @anchpop/neuron-recipies-refactor branch from 923f0a3 to 634c864 Compare July 30, 2024 17:42

anchpop force-pushed the @anchpop/NNS1-3207 branch from b1b8d65 to 82db927 Compare July 30, 2024 21:54